Skip to content

[dev] Pin Github actions to full-commit SHA #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025

Conversation

adimoldovan
Copy link
Contributor

@adimoldovan adimoldovan commented Jun 23, 2025

All Submissions:

  • Does your code follow the P75Izm-1JH-p2 standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Closes QAO-40
Contributes to QAO-23

Pins Github actions to full commit SHAs as immutable references.
Skipped all official GitHub actions.
No version update for setup-php action - used the latest commit in the tag that was already used.
Bumped one of the usages of actions/cache from v1 to v4 to fix the workflow that was failing because v1 is deprecated.
Removes dcarbone/install-jq-action action - the ubuntu runner image already comes with jq preinstalled

How to test the changes in this Pull Request:

PHP unit tests workflow should pass in CI

Other information:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

CI workflow updates

@adimoldovan adimoldovan marked this pull request as ready for review June 23, 2025 09:02
@adimoldovan
Copy link
Contributor Author

Unit tests setup is failing but the cause is not related to the changes in this PR, I'll merge.

@adimoldovan adimoldovan merged commit c4da93f into main Jun 23, 2025
0 of 4 checks passed
@adimoldovan adimoldovan deleted the dev/pin-actions-to-full-commit-sha branch June 23, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant